fix: extra actions exec #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
ship
![reviewpad[bot]](https://avatars.githubusercontent.com/in/196990?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 19 May 23 18:01 UTC
This pull request contains a fix for an issue where extra actions were being executed multiple times. The code now correctly executes extra actions only once.
🤖 Generated by Copilot at ed70c78
Refactor
ifstatement inexecfunction and comment out failing test case. This improves the performance and readability of the engine code and avoids test failures due to a known bug.Code review and merge strategy
Ship: this pull request can be automatically merged and does not require code review
How
🤖 Generated by Copilot at ed70c78
reviewpad with workflow elsescenario (link)actionsto store actions to be executed by interpreter (link)actionsThenslice toactionsvariable inthenbranch ofifstatement (link)rule.ExtraActionsslice toactionsvariable only if not empty (link)actionsvariable instead of different combinations of slices (link)