Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple pipelines execution #926

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

ferreiratiago
Copy link
Member

@ferreiratiago ferreiratiago commented May 31, 2023

Description

Summary generated by Reviewpad on 31 May 23 13:48 UTC

This pull request contains changes to multiple files. It adds new YAML pipelines for testing with various triggers and stages, modifies the "ExecConfigurationFile" function in "engine/exec.go" to check for activation and "until" conditions, and adds a new test case for the "exec" package with expected output.

馃 Generated by Copilot at abf01e3

This pull request enhances the pipeline execution feature in reviewpad, by improving the logging, performance, and testing of the ./engine/exec.go module. It adds log messages, refactors the stage execution logic, and introduces a new test case and test data file.

Related to

#924

Code review and merge strategy

Ship: this pull request can be automatically merged and does not require code review

How

馃 Generated by Copilot at abf01e3

  • Add a test case for the exec configuration file function (link)
    • Use a test data file with different pipeline configurations (engine/testdata/exec/reviewpad_with_pipelines.yml) (link)
  • Refactor the logic of executing pipeline stages (link)
  • Improve the log output of the pipeline processing (link)

@reviewpad reviewpad bot added ship Pull request can be automatically merged and does not require code review large large pull request labels May 31, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request has git conflicts. Please fix them.

@ferreiratiago ferreiratiago added the do-not-merge Pull request cannot be merged label May 31, 2023
@ferreiratiago ferreiratiago force-pushed the fix/multiple-pipelines-execution branch from abf01e3 to c073c7b Compare May 31, 2023 13:45
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request is not rebaseable. Please rebase it manually.

@ferreiratiago ferreiratiago force-pushed the fix/multiple-pipelines-execution branch from c073c7b to a6d9086 Compare May 31, 2023 13:48
@ferreiratiago ferreiratiago removed the do-not-merge Pull request cannot be merged label May 31, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request is in ship mode. Reviewpad will merge it.

@reviewpad reviewpad bot merged commit f1b339c into main May 31, 2023
3 checks passed
@reviewpad reviewpad bot deleted the fix/multiple-pipelines-execution branch May 31, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large large pull request ship Pull request can be automatically merged and does not require code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant