Make Cache-Control Header Configurable #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable called AWS_CACHE_CONTROL.
tiandavis
changed the title
fizker
suggested changes
Apr 16, 2018
|
Looks perfect! :) |
tiandavis
added a commit
to thirdiron/browzine-discovery-service-adapters
that referenced
this pull request
Apr 17, 2018
…ironment variable. See, PR revisohq/deploy-web-to-s3#6
tiandavis
added a commit
to thirdiron/browzine-discovery-service-adapters
that referenced
this pull request
Apr 17, 2018
…ironment variable. See, PR revisohq/deploy-web-to-s3#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fizker and @revisohq Team!
This PR exposes the S3 file Cache-Control header as a configurable environment variable called
AWS_CACHE_CONTROL. So if we wanted a 90 day cache instead of the default 30 day cache, we could run:Looks good?
We're using
deploy-web-to-s3on CircleCI to deploy some SDK assets to S3. It's worked perfectly so far, so just wanted to also take some time to say Thank You!