Database integrity check failing during upgrade to 4.1.0

[mbeccati]

If the database with created with some old OpenX Source or phpAdsNew version, chances are that it cannot be upgraded to Revive Adserver 4.1.0 due to some fields not passing the integrity check.

That happens because the database comparison algorithm used by Revive Adserver has always been ignoring any difference in DEFAULT or NOT NULL constraints, which is something that has been rectified in 4.1.0. The impossibility to create an upgrade package that was altering a default value was what led to the discovery and fix itself.

We had been testing a number of upgrades from OpenX 2.8.11 and previous versions of Revive Adserver, to 4.1.0 thinking that was enough. We trusted that the existing upgrade packages that had been developed during the years would bring any database schema precisely to what a fresh 2.8.11 install would have been, but that's now clearly not true. Possibly due to the aforementioned bug, the upgrade packages are not 100% accurate and no one ever noticed that upgraded databases were in fact slightly different from freshly installed ones.

That is the reason why 4.1.0 complains loudly about it and won't allow upgrading such databases further, which is something we urgently need to fix.