Pipeline revng passes #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drblallo
force-pushed
the
feature/pipeline-revng-passes
branch
from
57fa58c
to
c242eeb
Compare
aleclearmind
requested changes
Feb 13, 2024
aleclearmind
requested changes
Feb 13, 2024
drblallo
force-pushed
the
feature/pipeline-revng-passes
branch
from
c242eeb
to
08f05de
Compare
aleclearmind
requested changes
Feb 21, 2024
Comment on lines
25
to
+26
| AU.addRequired<LoadModelWrapperPass>(); | ||
| AU.addRequired<pipeline::LoadExecutionContextPass>(); |
There was a problem hiding this comment.
Why do we still need LoadModelWrapperPass?
We can get the model from the ExecutionContext, can't we?
There was a problem hiding this comment.
yes, but we need to schedule LOadModelWrapperPAss anyway so people can do both. Do we wish to have a policy about this? in principle we could even entirely drop LoadModelWrapperPass
There was a problem hiding this comment.
i looked into this, but the change was sprawling and it still requires to make sure that revng opt is never used. I recommend to do it after after that issue is fixed
drblallo
force-pushed
the
feature/pipeline-revng-passes
branch
4 times, most recently
from
443675e
to
c21dc30
Compare
aleclearmind
requested changes
Feb 23, 2024
drblallo
force-pushed
the
feature/pipeline-revng-passes
branch
from
c21dc30
to
040829d
Compare
Propagates the deduced info about inputs and outputs of pipes all the way up to the runner, so that the requested output of a pipe can be passed to its invokation
drblallo
force-pushed
the
feature/pipeline-revng-passes
branch
from
040829d
to
31a5432
Compare
|
Closing this due to the heavy reworking I'm doing on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.