Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sessions): Add confirmation prompt (reopened) #575

Merged
merged 2 commits into from May 7, 2022
Merged

feat(sessions): Add confirmation prompt (reopened) #575

merged 2 commits into from May 7, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2022

Reopening of issue #572
Fixes issue #42
Translations added on PR 31 of revolt/translations


  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended
  • These changes do not have any notable side effects on other Revolt projects
  • (optional) I have opened a pull request on the translation repository
  • I have included screenshots to demonstrate my changes
brave_ygPHXCuPLd.mp4

Reopening of issue #572
Fixes issue #42
Translations added on PR 31 of revolt/translations
@ghost
Copy link
Author

ghost commented Apr 6, 2022

Accidentally closed previous PR due to deleting and redoing my own fork. Requested changes were made.

VulpoTheDev
VulpoTheDev previously approved these changes Apr 8, 2022
@insertish
Copy link
Member

Conflicting, please merge master

@insertish insertish merged commit ac0c100 into revoltchat:master May 7, 2022
@insertish insertish mentioned this pull request May 8, 2022
6 tasks
@ghost ghost deleted the sessions-modal branch June 19, 2022 03:06
lynxize pushed a commit to lynxize/revite-nonsense that referenced this pull request Sep 18, 2023
Reopening of issue revoltchat#572
Fixes issue revoltchat#42
Translations added on PR 31 of revolt/translations

Co-authored-by: Paul Makles <paulmakles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants