feat: add a search field to server bans #579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
True and holy in nature. EGN 12/10 |
EnokiUN
previously approved these changes
Apr 10, 2022
|
Conflicting |
not anymore |
insertish
requested changes
Apr 29, 2022
src/pages/settings/server/Bans.tsx
Outdated
Comment on lines
88
to
93
| data.users | ||
| .find( | ||
| (u) => | ||
| u._id == data.bans[index]._id.user, | ||
| ) | ||
| ?.username.toLowerCase() |
There was a problem hiding this comment.
This is a pretty big performance penalty which should be memo-ized.
There was a problem hiding this comment.
useMemo, useCallback just prevents the function from being recreated, while useMemo keeps the result between renders and also you don't call it every time you render an item
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to check the following tasks before opening and submitting a PR
Adds a search bar to the server ban list:
(I copypasted the search bar from the member list, hence the lack of localization)