Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ability to set appearance of Focus status and remove unused refer… #968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ability to set appearance of Focus status and remove unused refer… #968

wants to merge 1 commit into from

Conversation

DeclanChidlow
Copy link
Member

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended
  • These changes do not have any notable side effects on other Revolt projects
  • (optional) I have opened a pull request on the translation repository
  • I have included screenshots to demonstrate my changes
  • Removed references to unused streaming status
  • Added ability to theme focus status in theme overrides settings
  • Standardised names of statuses
  • Ran a format

image
(ignore colours, just for testing)

insertish
insertish requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@insertish insertish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine but see review comment.

src/context/Theme.tsx
@@ -30,10 +30,9 @@ export type Variables =
| "tertiary-foreground"
| "tooltip"
| "status-online"
| "status-away"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While revite is in maintenance mode, it seems pointless to break existing themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insertish insertish insertish requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Pull Request Overview
Status: 🛑 Changes requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DeclanChidlow @insertish