feat: video player #29
Conversation
I like using !1, !0 and void 0, but thats not professional
Audio players can sync on android background audio service, it needs background task config to completely work.
I cannot explain why, but the app crashes once with no errors. If it gives problems, this feat can be removed.
+ exports/imports from index
|
out of curiosity, what failed when trying to install the first library? |
$ yarn add @carchaze/react-native-voice-message-player
<--- JS stacktrace --->
FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
1: 0x55916db37f30 node::Abort() [node]
2: 0x55916da30f4b [node]
3: 0x55916dd538a0 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
|
|
ahhh. there seems to be an issues where the latest releases of React Native - and, by extension, packages that depend on them - can't be installed due to a Yarn bug; your alternate solution should be fine (although it'd be preferable to fix the known issues first), and the seeming solution to this issue is to switch to Yarn Berry (I'll wait for v4 to release) so no worries |
|
Conflicting |
|
Hi! As you said before I tried to install (in new branch) |
|
I will also mention that you might be able to follow the steps here if you haven't already - however, if you have to no avail, no worries. I think splitting this PR would be a good idea regardless; take as much time as you need ^^ |
|
hehe that task doesnt exist in the gradle project, then I manually deleted ~/.gradle/cache. |
Reasons commented in this PR
| @@ -4,3 +4,5 @@ export {MessageEmbed} from './MessageEmbed'; | |||
| export {MessageReactions} from './MessageReactions'; | |||
| export {PlatformModerationMessage} from './PlatformModerationMessage'; | |||
| export {ReplyMessage} from './ReplyMessage'; | |||
| export {VideoEmbed} from './VideoEmbed'; | |||
| export {AudioPlayer} from './AudioPlayer'; | |||
There was a problem hiding this comment.
With the splitting of this PR, this needs to be removed
| @@ -1,4 +1,5 @@ | |||
| import {ToastAndroid} from 'react-native'; | |||
| import TrackPlayer, {Event} from 'react-native-track-player'; | |||
Features
Video player
In message, video opens as preview. Full-screen control activates full mode (it pauses preview and opens video on modal).
Modal contains same header as image viewer modal, with similar actions.
I haven't implemented video player in MessageEmbed yet.
Audio player
It was hard to find an audio player component. I tried installing a voice message player but installation failed. Then, I built my own component using TrackPlayer, a service useful for music queues, and I implemented a method to ensure that only one audio is played at a time.
Some known bugs:
Please make sure to check the following tasks before opening and submitting a PR