Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let empty hexes store as well #70

Closed
jjonj opened this issue Nov 9, 2013 · 10 comments
Closed

let empty hexes store as well #70

jjonj opened this issue Nov 9, 2013 · 10 comments

Comments

@jjonj
Copy link
Contributor

jjonj commented Nov 9, 2013

Vacuoles should not be specialized storage as it is now, but be able to hold a mixture of compounds.
The discussion can be found in this thread from halfway down:
http://thrivegame.forum-free.ca/t997p150-microbial-compounds-and-organelles

@LetterShapedGlyphs
Copy link

I have to get working on a project right now, but if no one is working on this currently I just read over the thread and would be interested in implementing it. (I'll submit the pull request when I'm done with my OS threading assignment)

@jjonj
Copy link
Contributor Author

jjonj commented Dec 7, 2013

You have been assigned :) btw you don't >need< to submit a pull request before you have some code to show, do it whenever

EDIT:
I don't think i have the necessary permissions to add you as a contributor on github (can't find it atleast) so i can't click you as assigned, but no matter, just go for it!

@LetterShapedGlyphs
Copy link

So... I finished rewriting the Storage Organelle class to be generalized and robust, as well as implementing bandwidth and variant compound sizes (everything is set to size 1 for now), and was about to edit the Microbe class to handle these changes when I noticed that the fundamental way that microbes absorbed compounds was defined in the engine... so since I'm going to be modifying agent.cpp ANYWAYS, should I merge this issue with the "rename agents to compounds" issue and just do that while I'm at it? It is making this in to quite a bit more refactoring than I originally anticipated but I'm already halfway there...

Edit: That is to say, the microbe used to call "setCanAbsorbAgent" when a vacuole was added, but since things are now 'generalized storage' that variable is deprecated and 'agent' absorption needs to be changed to reflect that.

ugh, scratch that. I'll split it into two things. I'll just make the microbe call setCanAbsorb for all 3 compound types manually when initialized and let someone else refactor and/or refactor it myself later.

@jjonj
Copy link
Contributor Author

jjonj commented Dec 7, 2013

You shouldn't worry about other issues being worked on, unless you would be doing huge restructuring. Just update the cpp/h files to match your new structure.

defined in the engine

We don't actually define everything in C++ to be the 'engine' part, but rather just implement things in the language where it makes more sense, a lot of the lua code should eventually be migrated to C++, but while it's new and experimental there's an advantage to keeping it in lua.

@jjonj
Copy link
Contributor Author

jjonj commented Mar 17, 2014

This will be finally fixed in #91

@jjonj jjonj changed the title Change vacuoles to be general storage and add let empty hexes store aswell Change vacuoles to be general storage and add let empty hexes store as well Mar 30, 2014
@jjonj
Copy link
Contributor Author

jjonj commented Apr 16, 2014

Everything has been fixed except for the empty hex storage, since we currently don't have empty hexes. This should follow from #115.

@jjonj jjonj changed the title Change vacuoles to be general storage and add let empty hexes store as well ~~Change vacuoles to be general storage and add~~ let empty hexes store as well Apr 18, 2014
@jjonj jjonj changed the title ~~Change vacuoles to be general storage and add~~ let empty hexes store as well -- let empty hexes store as well Apr 18, 2014
@jjonj jjonj removed their assignment Apr 27, 2014
@Moopli
Copy link
Contributor

Moopli commented Jul 11, 2014

Technically this doesn't require 115 in any way -- we just make a new "cytoplasm" organelle, and modify the organelle-placement-checks in microbe_editor.lua to remove cytoplasm before placing the new organelle.

@jjonj
Copy link
Contributor Author

jjonj commented Jul 11, 2014

True, however I'm not a fan of throwing work at it for an organelle type that will be removed in the not-too-distant future

@Moopli
Copy link
Contributor

Moopli commented Sep 15, 2014

Thinking on this again it hits me that an empty cytoplasm organelle would probably be the cleanest way to handle this internally, regardless what it looks like to the player. Since I forgot to ask before, why would an invisible-to-player cytoplasm organelle be removed in the not-too-distant future?

@Moopli Moopli changed the title -- let empty hexes store as well let empty hexes store as well Sep 15, 2014
@jjonj
Copy link
Contributor Author

jjonj commented Feb 19, 2015

replaced by the more relevant #291

@jjonj jjonj closed this as completed Feb 19, 2015
hhyyrylainen added a commit that referenced this issue May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants