-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let empty hexes store as well #70
Comments
I have to get working on a project right now, but if no one is working on this currently I just read over the thread and would be interested in implementing it. (I'll submit the pull request when I'm done with my OS threading assignment) |
EDIT: |
So... I finished rewriting the Storage Organelle class to be generalized and robust, as well as implementing bandwidth and variant compound sizes (everything is set to size 1 for now), and was about to edit the Microbe class to handle these changes when I noticed that the fundamental way that microbes absorbed compounds was defined in the engine... so since I'm going to be modifying agent.cpp ANYWAYS, should I merge this issue with the "rename agents to compounds" issue and just do that while I'm at it? It is making this in to quite a bit more refactoring than I originally anticipated but I'm already halfway there... Edit: That is to say, the microbe used to call "setCanAbsorbAgent" when a vacuole was added, but since things are now 'generalized storage' that variable is deprecated and 'agent' absorption needs to be changed to reflect that. ugh, scratch that. I'll split it into two things. I'll just make the microbe call setCanAbsorb for all 3 compound types manually when initialized and let someone else refactor and/or refactor it myself later. |
You shouldn't worry about other issues being worked on, unless you would be doing huge restructuring. Just update the cpp/h files to match your new structure.
We don't actually define everything in C++ to be the 'engine' part, but rather just implement things in the language where it makes more sense, a lot of the lua code should eventually be migrated to C++, but while it's new and experimental there's an advantage to keeping it in lua. |
This will be finally fixed in #91 |
Everything has been fixed except for the empty hex storage, since we currently don't have empty hexes. This should follow from #115. |
Technically this doesn't require 115 in any way -- we just make a new "cytoplasm" organelle, and modify the organelle-placement-checks in microbe_editor.lua to remove cytoplasm before placing the new organelle. |
True, however I'm not a fan of throwing work at it for an organelle type that will be removed in the not-too-distant future |
Thinking on this again it hits me that an empty cytoplasm organelle would probably be the cleanest way to handle this internally, regardless what it looks like to the player. Since I forgot to ask before, why would an invisible-to-player cytoplasm organelle be removed in the not-too-distant future? |
replaced by the more relevant #291 |
Vacuoles should not be specialized storage as it is now, but be able to hold a mixture of compounds.
The discussion can be found in this thread from halfway down:
http://thrivegame.forum-free.ca/t997p150-microbial-compounds-and-organelles
The text was updated successfully, but these errors were encountered: