Is can_request_send method correct?

[hisyatokaku]

The code below seems to check if request can be sent from 'from_user' to 'to_user'

    def can_request_send(self, from_user, to_user):
        """ Checks if a request was sent """
        if from_user == to_user or FriendshipRequest.objects.filter(
            from_user=from_user,
            to_user=to_user,
            ).exists() is False:
            return False
        else: 
            return True

The method returns False when the request from 'from_user' to 'to_user' has NOT been made yet, which seems to be opposite.
Should is False be changed to is True ?

https://github.com/revsys/django-friendship/blob/master/friendship/models.py

[uri-rodberg]

    if from_user == to_user or FriendshipRequest.objects.filter(
        from_user=from_user,
        to_user=to_user,
        ).exists() is False:

I recommend to use parentheses because it's not clear what is False refers to.

Also, maybe not is better than is False.

[uri-rodberg]

In this case maybe you should just remove is False?

[uri-rodberg]

        if self.can_request_send(from_user, to_user):
            raise AlreadyExistsError("Friendship already requested")

I'm also not sure if this code is correct.

[umbertov]

It should be

    if from_user == to_user or not FriendshipRequest.objects.filter(
        from_user=from_user,
        to_user=to_user,
        ).exists():

And

if not self.can_request_send:
    raise  AlreadyExistsError (...)

Pardon formatting errors I'm on my phone

If somebody with write rights sees this maybe he can do the commit

[uri-rodberg]

#88

[umbertov]

Is this library still maintained?

[uri-rodberg]

Is this library still maintained?

Last commit more than 3 months ago. But I'm not sure.

[frankwiles]

@hisyatokaku yes the method is correct. I just refactored it a bit to make it slightly more clear.