Fixed issue https://github.com/revsys/django-friendship/issues/86 + reformat code. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
uri-rodberg
commented
Apr 25, 2019
•
uri-rodberg
commented
- Fixed issue & tests.
|
|
Appreciate the work on this and apologies that we didn't get to it sooner, but I just ran Black over the whole codebase and refactored the method before I saw this PR sadly. |
@frankwiles You ignored all this pull request and didn't fix other issues such as -1 |
|
@uri-rodberg that’s not how it works. Your PR was merged in about a month, which is IMHO is a totally acceptable time frame in open source. I don’t know why you think you can demand first-class support for a software you’re not paying for. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.