feat: Add support for allowed aspect ratios [CC-708] #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iirovi-rs
changed the title
iirovi-rs
requested review from
zeph-cohen10,
aylwing-rewardstyle and
MikkoKuivanenRS
zeph-cohen10
reviewed
Mar 7, 2024
| @@ -305,7 +302,50 @@ fileprivate extension YPAssetZoomableView { | |||
| self?.centerAssetView() | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| func findClosestAllowedAspectRatio(for aspectRatio: CGFloat) -> CGFloat { | |||
There was a problem hiding this comment.
This would be nice to have a test for but we don't have that established in the image picker library nor do we have the CI infrastructure setup to run tests even if we did have them here 🤔
There was a problem hiding this comment.
Yeah true. Maybe it would be worth it to just add a simple unit test file for this, even if it's not automated in the CI.
iirovi-rs
force-pushed
the
feat/CC-708-allowed-aspect-ratios
branch
from
873a271
to
d2a0cc9
Compare
iirovi-rs
force-pushed
the
feat/CC-708-allowed-aspect-ratios
branch
from
a3a8d78
to
ba6e260
Compare
iirovi-rs
changed the base branch from
CC-550-when-selecting-media-display-auto-cropping-for-additionally-selected-media-assets
to
master
| @@ -234,6 +237,15 @@ open class LibraryMediaManager { | |||
| } else { | |||
| // transfer the transform so the video renders in the correct orientation | |||
| videoCompositionTrack.preferredTransform = transform | |||
| videoComposition?.renderSize = videoSize | |||
There was a problem hiding this comment.
On line 236, can probably clean up that comment right? I think we determined that videoComposition?.renderSize = cropRect.size is needed? (based on Slack convo)
There was a problem hiding this comment.
Oh yeah sure, I'll clean it up.
iirovi-rs
force-pushed
the
feat/CC-708-allowed-aspect-ratios
branch
from
ba6e260
to
aa915ae
Compare
zeph-cohen10
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a bunch of configuration variables allowing setting lists of "allowed aspect ratios" for single-video and multi-asset scenarios. The videos (or media, in the case of multiple selection) will be auto-cropped to the nearest aspect ratio from the list. An "override" list is also provided for both scenarios (single video and multi-selection), allowing for a situation where we'll want to allow certain aspect ratios to be "always allowed" but never selected automatically.
Additionally, it adds a configuration value for "max video resolution", which allows setting a maximum value for the resulting processed video's pixel count (height * width). It also automatically rounds the resulting width and height values to the nearest even number, which is a requirement for many video post processing use cases.