Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement extended opcode LVEHX correctly #18

Closed
sumit0190 opened this issue Oct 18, 2017 · 22 comments
Closed

Implement extended opcode LVEHX correctly #18

sumit0190 opened this issue Oct 18, 2017 · 22 comments

Comments

@sumit0190
Copy link
Contributor

I tried running decompile on the XEX for XEXMenu , and near the end of the decoding process, I got the error:
Unmatched secondary opcode 39 for primary 31

I checked the ISA and saw that opcode 39 corresponded to lvehx, so I modified the switch-case inside xenonInstructionDecoding.cpp to use EMIT(lvehx, VREG(b6), MEMREG0(b11,b16)). The process then continued fine, although I got a bunch of "decoded address value is outside range" warnings.

When I ran recompile on the output, I saw a few 'undeclared identifier' errors. In one of the generated files, TREG is used as an identifier but not declared anywhere.

Any ideas on what might be going on?

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@sumit0190
Copy link
Contributor Author

The fact that you can decompile huge games is highly impressive! I've only been trying small XBLA games for now, along with some homebrew I made or had lying around. I am sure this must be a merge issue then.

Did I emit the opcode correctly though? My knowledge of PPC ISA is hazy.

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@sumit0190
Copy link
Contributor Author

Yeah, the missing APIs are a pain to deal with. It' still a massive achievement though.

Oh, and thanks for adding XEXMenu to the bundled projects! 👍

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@sumit0190
Copy link
Contributor Author

But you were able to recompile it? I saw the changes on your other branch that you just merged - doesn't look like I did anything different than what you have for lvehx, but I couldn't get past the recompilation.

I'll pull your other branch and give it a go.

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@sumit0190
Copy link
Contributor Author

I am very curious to see what these functions are; would love to have a go at it and implement a few.

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@sumit0190
Copy link
Contributor Author

Yeah, I just grabbed your latest changes and got through recompilation - I get the same result. That's a long list, but we can do it!

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@sumit0190
Copy link
Contributor Author

I agree. I don't have access to the original help files, but are those hard to find on the internet as well?

I can work on some of the stubs if you don't mind.

@rexdex
Copy link
Owner

rexdex commented Oct 18, 2017 via email

@sumit0190
Copy link
Contributor Author

sumit0190 commented Oct 18, 2017

I've wrote you an private email on the address you list in your github account regarding the help files. I don't think they are publicly available.

That's really helpful, thanks!

The User one is shitty as I see that I need to emulate a proper "user" with attributes and such :(

I personally don't know much about that part but back in the 360 days when I was writing homebrew I was able to find a few resources online about it. Let me see if I can find them.

@pablo67340
Copy link

Did anything come of this project? It would be groundbreaking to have some sort of XeXMenu source files.

@rexdex
Copy link
Owner

rexdex commented Aug 22, 2020

I was working for Microsoft for a while after I did this project and I have to suspend it so I didn't post any updates. That's all I can write :(

@pablo67340
Copy link

I was working for Microsoft for a while after I did this project and I have to suspend it so I didn't post any updates. That's all I can write :(

Would you be willing to talk about this in private?

Email: pablo67340@gmail.com
Discord: Bryce#0001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants