Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount point for volumes conflicts with Docker local volumes #27

Closed
clintkitson opened this issue Aug 27, 2015 · 9 comments
Closed

Mount point for volumes conflicts with Docker local volumes #27

clintkitson opened this issue Aug 27, 2015 · 9 comments
Assignees
Milestone

Comments

@clintkitson
Copy link
Member

/var/lib/docker/volumes/testa16

The volume mount point that is used should be outside of /var/lib/docker/volumes and likely associated to the volume manager. Something like /var/lib/rexray/volumes would suffice.

moby/moby#15880 (comment)

@clintkitson clintkitson added this to the 0.2.0 milestone Sep 14, 2015
@akutz
Copy link
Member

akutz commented Sep 15, 2015

Hi @clintonskitson,

I don't think I changed this code from the original, so it's likely what you had it. Are you asking me to change it because you want it relocated, or because you think I changed it from its original location? I only ask because I want to make sure that we have checks in place to ensure the suggested path exists.

@clintkitson
Copy link
Member Author

I will make the change here and add a PR.

@akutz
Copy link
Member

akutz commented Sep 15, 2015

Hi Clint,

Let me as I want to move the path to the config area. Unless you want to create a config variable with default options.

-a

"I wonder if procrastinators realize that they're not putting off work, just putting it off onto other people?"

On Sep 15, 2015, at 10:51 AM, Clinton Kitson notifications@github.com wrote:

I will make the change here and add a PR.


Reply to this email directly or view it on GitHub #27 (comment).

@clintkitson
Copy link
Member Author

Nope, feel free. If its a simple change to make it configurable, then I say go for it. Otherwise, the only operational complexity I see with that is possibly having multiple RR instances running and the same volume trying to be mounted across the instances. The first instance may allow it, but the second would atttempt it as well and likely fail.

I believe having a single path for both instances would be the best approach. But I might differ from that if we said that all RR instances have the single path.

@clintkitson
Copy link
Member Author

Let me clarify..

  1. Allow each RR instance to have its own mount path
  2. Allow configurable mount path for all instances
  3. Don't allow configurable mount path

I would be in for #2 or #3 right now.

@akutz
Copy link
Member

akutz commented Sep 15, 2015

Hi @clintonskitson,

Don't get me wrong, I think it should absolutely be a single path for all instances. I do believe however that that path should be configurable.

@clintkitson
Copy link
Member Author

Agree there

@akutz
Copy link
Member

akutz commented Sep 15, 2015

Yep, on same page.

@akutz
Copy link
Member

akutz commented Sep 15, 2015

Hi @clintonskitson,

We're going to have to do # 3 for now as there's no good way to restrict a config value once set to be used for all instances. I know how I will do it, but it will involve too much work for this release.

@akutz akutz mentioned this issue Sep 15, 2015
@akutz akutz closed this as completed Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants