Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sirupsen to sirupsen #995

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Sirupsen to sirupsen #995

merged 1 commit into from
Aug 31, 2017

Conversation

akutz
Copy link
Member

@akutz akutz commented Aug 31, 2017

This patch handles the chaos caused when the Github user account Sirupsen was renamed to sirupsen.

This patch handles the chaos caused when the Github user account
Sirupsen was renamed to sirupsen.
@akutz akutz added this to the 2017.09-1 milestone Aug 31, 2017
@akutz akutz requested a review from codenrhoden August 31, 2017 18:41
@codecov-io
Copy link

codecov-io commented Aug 31, 2017

Codecov Report

Merging #995 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
+ Coverage   34.11%   34.15%   +0.03%     
==========================================
  Files          36       36              
  Lines        2896     2896              
==========================================
+ Hits          988      989       +1     
+ Misses       1806     1805       -1     
  Partials      102      102
Impacted Files Coverage Δ
libstorage/api/utils/utils_store.go 26.85% <ø> (ø) ⬆️
...orage/drivers/storage/vfs/executor/vfs_executor.go 63.33% <ø> (ø) ⬆️
libstorage/api/types/types_config_compat.go 0% <ø> (ø) ⬆️
libstorage/api/utils/utils_logging.go 0% <ø> (ø) ⬆️
libstorage/api/utils/utils_auth.go 0% <ø> (ø) ⬆️
libstorage/api/context/context.go 30.82% <ø> (ø) ⬆️
libstorage/api/utils/schema/schema.go 45.07% <ø> (ø) ⬆️
libstorage/api/context/context_logger.go 12.61% <ø> (ø) ⬆️
libstorage/api/utils/utils_tls.go 0% <ø> (ø) ⬆️
libstorage/api/types/types_localdevices.go 88.23% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3443713...1967562. Read the comment docs.

@akutz akutz merged commit 78e95e6 into rexray:master Aug 31, 2017
@akutz akutz deleted the feature/sirupsen branch August 31, 2017 19:45
@akutz
Copy link
Member Author

akutz commented Aug 31, 2017

Hi @codenrhoden,

I was working for a while trying to undo some of this PR and instead update only the dependencies necessary to solve the logrus issue. However, golang/dep#1104 partially explains why this isn't possible. Due to the way Dep solves constraints, dep ensure -update github.com/akutz/gofig fails because the entire resolution must occur before updating only gofig. However, the resolution fails because of the original logrus issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants