Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes URLs for Docs viewed on Github #337

Merged
merged 2 commits into from Apr 16, 2016

Conversation

akutz
Copy link
Member

@akutz akutz commented Mar 7, 2016

This patch fixes the links in the .docs markdown so that the docs work both when viewed through RTD as well as when viewed on Github.

This PR handles issue #336.

@akutz
Copy link
Member Author

akutz commented Mar 7, 2016

Hi @cantbewong & @clintonskitson,

Would you both please review the PRs docs on Github for broken URLs. Thanks!

This patch fixes the links in the .docs markdown so that the docs work
both when viewed through RTD as well as when viewed on Github.
@clintkitson clintkitson modified the milestones: 0.3.3, 0.4.0 Apr 9, 2016
@clintkitson clintkitson assigned akutz and unassigned cantbewong Apr 16, 2016
@clintkitson
Copy link
Member

Reviewed, LGTM

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c0bd53e on akutz:bugfix/doc-gh-url-fix into * on emccode:master*.

@codecov-io
Copy link

Current coverage is 91.08%

Merging #337 into master will not affect coverage as of 7807dc1

@@            master    #337   diff @@
======================================
  Files            8       8       
  Stmts          729     729       
  Branches        14      14       
  Methods          0       0       
======================================
  Hit            664     664       
  Partial         14      14       
  Missed          51      51       

Review entire Coverage Diff as of 7807dc1


Uncovered Suggestions

  1. +1.37% via ...re/drivers_volume.go#183...192
  2. +1.23% via ...re/drivers_volume.go#344...352
  3. +0.96% via ...re/drivers_volume.go#220...226
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@akutz akutz merged commit 1d2027f into rexray:master Apr 16, 2016
@akutz akutz deleted the bugfix/doc-gh-url-fix branch April 16, 2016 20:33
akutz added a commit to akutz/rexray that referenced this pull request Apr 17, 2016
NEW FEATURES
- ScaleIO v2 support rexray#355
- EC2 Tags added to Volumes & Snapshots rexray#314

ENHANCEMENTS
- Use of official Amazon EC2 SDK rexray#359
- Added a disable feature for create/remove volume rexray#366
- Added ScaleIO troubleshooting information rexray#367

BUG FIXES
- Fixes URLs for documentation when viewed via Github rexray#337
- Fixes logging bug on Ubuntu 14.04 rexray#377
- Fixes module start timeout error rexray#376
- Fixes ScaleIO authentication loop bug rexray#375

THANK YOU
- Philipp Franke (https://github.com/philippfranke)
- Eugene Chupriyanov (https://github.com/echupriyanov)
- Peter Blum https://github.com/oskoss)
- Megan Hyland https://github.com/meganmurawski)
akutz added a commit to akutz/rexray that referenced this pull request Apr 21, 2016
NEW FEATURES
- ScaleIO v2 support rexray#355
- EC2 Tags added to Volumes & Snapshots rexray#314

ENHANCEMENTS
- Use of official Amazon EC2 SDK rexray#359
- Added a disable feature for create/remove volume rexray#366
- Added ScaleIO troubleshooting information rexray#367

BUG FIXES
- Fixes URLs for documentation when viewed via Github rexray#337
- Fixes logging bug on Ubuntu 14.04 rexray#377
- Fixes module start timeout error rexray#376
- Fixes ScaleIO authentication loop bug rexray#375

THANK YOU
- Philipp Franke (https://github.com/philippfranke)
- Eugene Chupriyanov (https://github.com/echupriyanov)
- Peter Blum https://github.com/oskoss)
- Megan Hyland https://github.com/meganmurawski)
@akutz akutz mentioned this pull request Apr 21, 2016
akutz added a commit that referenced this pull request Apr 21, 2016
NEW FEATURES
- ScaleIO v2 support #355
- EC2 Tags added to Volumes & Snapshots #314

ENHANCEMENTS
- Use of official Amazon EC2 SDK #359
- Added a disable feature for create/remove volume #366
- Added ScaleIO troubleshooting information #367

BUG FIXES
- Fixes URLs for documentation when viewed via Github #337
- Fixes logging bug on Ubuntu 14.04 #377
- Fixes module start timeout error #376
- Fixes ScaleIO authentication loop bug #375

THANK YOU
- Philipp Franke (https://github.com/philippfranke)
- Eugene Chupriyanov (https://github.com/echupriyanov)
- Peter Blum https://github.com/oskoss)
- Megan Hyland https://github.com/meganmurawski)
akutz added a commit that referenced this pull request Apr 21, 2016
NEW FEATURES
- ScaleIO v2 support #355
- EC2 Tags added to Volumes & Snapshots #314

ENHANCEMENTS
- Use of official Amazon EC2 SDK #359
- Added a disable feature for create/remove volume #366
- Added ScaleIO troubleshooting information #367

BUG FIXES
- Fixes URLs for documentation when viewed via Github #337
- Fixes logging bug on Ubuntu 14.04 #377
- Fixes module start timeout error #376
- Fixes ScaleIO authentication loop bug #375

THANK YOU
- Philipp Franke (https://github.com/philippfranke)
- Eugene Chupriyanov (https://github.com/echupriyanov)
- Peter Blum https://github.com/oskoss)
- Megan Hyland https://github.com/meganmurawski)
@akutz akutz mentioned this pull request Apr 22, 2016
akutz added a commit to akutz/rexray that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants