Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ec2 tags to volumes and snapshots (Updated for release-0.3.3) #358

Merged
merged 1 commit into from
Apr 17, 2016

Conversation

echupriyanov
Copy link
Contributor

Updated PR against release-0.3.3 branch

Signed-off-by: Eugene Chupriyanov tchu@tchu.ru

Signed-off-by: Eugene Chupriyanov <tchu@tchu.ru>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.193% when pulling 1bc0517 on echupriyanov:ec2tags-0.3.3 into 806dc9b on emccode:release/0.3.3.

@clintkitson
Copy link
Member

Waiting on merge of #359 and must be rebased from there.

@miry
Copy link

miry commented Apr 15, 2016

@echupriyanov You can add only 1 tag as I understand, the tag key name is static to rexraySet. Correct?

Is it possible to specify custom key/value tags ?

@echupriyanov
Copy link
Contributor Author

@miry Yes. In this PR tag is hard-coded to be rexraySet.
But, since this PR is going to be rewritten based on official AWS SDK, I’m open for suggestions on how to improve it.

Custom tag keys/values is a good idea. I’ll think how to implement it.

@clintkitson clintkitson modified the milestones: 0.4.0, 0.3.3 Apr 16, 2016
@akutz
Copy link
Member

akutz commented Apr 17, 2016

Hi @echupriyanov,

I'd love to merge this for 0.3.3, but you'll need to rebase this off of 0.3.3 to incorporate your ec2 SDK changes. I started to merge it myself, but I ran into enough compile issues that I decided to "delegate" it back to you :)

@akutz
Copy link
Member

akutz commented Apr 17, 2016

Hi @echupriyanov / @clintonskitson,

I went ahead and created a merge branch with the above changes. If you want, you can just update your PR branch to reflect the linked patch.

@akutz akutz merged commit 1bc0517 into rexray:release/0.3.3 Apr 17, 2016
@akutz
Copy link
Member

akutz commented Apr 17, 2016

Hi @echupriyanov / @clintonskitson,

I merged this so we can push a 0.3.3-RC1 sooner than later. If there are issues with it we can revert it.

@akutz akutz modified the milestones: 0.3.3, 0.4.0 Apr 17, 2016
@echupriyanov
Copy link
Contributor Author

@akutz sorry, was offline this weekend and didn’t help you to prepare PR. Hope to be more useful next time.

@clintkitson
Copy link
Member

clintkitson commented Apr 18, 2016

@echupriyanov Could you test RC1 with your changes?

@echupriyanov
Copy link
Contributor Author

@clintonskitson sure. I plan to build testing swarm cluster tomorrow, and will install RC1 on it.

@akutz
Copy link
Member

akutz commented Apr 18, 2016

Hi @echupriyanov, no worries! Thank you so much for the initial work on this and the other branch. Just at a glance though does this look like I captured your changes correctly?

akutz added a commit to akutz/rexray that referenced this pull request Jul 24, 2017
Fix for client not sending encryption key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants