-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ec2 tags to volumes and snapshots (Updated for release-0.3.3) #358
Conversation
Signed-off-by: Eugene Chupriyanov <tchu@tchu.ru>
Waiting on merge of #359 and must be rebased from there. |
@echupriyanov You can add only 1 tag as I understand, the tag key name is static to Is it possible to specify custom key/value tags ? |
@miry Yes. In this PR tag is hard-coded to be Custom tag keys/values is a good idea. I’ll think how to implement it. |
Hi @echupriyanov, I'd love to merge this for 0.3.3, but you'll need to rebase this off of 0.3.3 to incorporate your ec2 SDK changes. I started to merge it myself, but I ran into enough compile issues that I decided to "delegate" it back to you :) |
Hi @echupriyanov / @clintonskitson, I went ahead and created a merge branch with the above changes. If you want, you can just update your PR branch to reflect the linked patch. |
Hi @echupriyanov / @clintonskitson, I merged this so we can push a 0.3.3-RC1 sooner than later. If there are issues with it we can revert it. |
@akutz sorry, was offline this weekend and didn’t help you to prepare PR. Hope to be more useful next time. |
@echupriyanov Could you test RC1 with your changes? |
@clintonskitson sure. I plan to build testing swarm cluster tomorrow, and will install RC1 on it. |
Hi @echupriyanov, no worries! Thank you so much for the initial work on this and the other branch. Just at a glance though does this look like I captured your changes correctly? |
Fix for client not sending encryption key
Updated PR against
release-0.3.3
branchSigned-off-by: Eugene Chupriyanov tchu@tchu.ru