RExec: Kill flow on unexpected messages #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: linse <sschirme@gmail.com>
Co-authored-by: linse <sschirme@gmail.com>
Co-authored-by: linse <sschirme@gmail.com>
Co-authored-by: Mindy <meetup@yomimono.org> Co-authored-by: linse <sschirme@gmail.com>
Instead of as debug messages. We would not want to hide these.
Co-Authored-By: C For C's Sake <cfcs@users.noreply.github.com>
We raise an exception if the arguments do not fit in the cstruct. Also some whitespace changes.
Try to reflect that it's the remote service exit code
|
The server flow doesn't kill the connection on unexpected messages. We should probably do the same for both server and client. What does the C implementation do? |
reynir
force-pushed
the
rexec_client_server-wip
branch
from
a3b09be
to
8c96707
Compare
|
Merged in mirage#61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kill the connection when another VM sends an unexpected message.