Skip to content

Commit

Permalink
finally get r01490.vtc right
Browse files Browse the repository at this point in the history
(i hope)

Trouble here is that in pool_herder(), we access pp->dry unprotected, so
we might see an old value, thus we might breed more than wthread_min
even if the dry condition does not exist any more.

So for the vtc, we need to wait until wthread_timeout has passed and the
surplus thread has been kissed to death.

Notice that this does not change with varnishcache#2942 because there the same
unprotected access happens to lqueue.
  • Loading branch information
nigoroll authored and rezan committed Jul 11, 2019
1 parent ef63bef commit a24797a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion bin/varnishtest/tests/r01490.vtc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ varnish v1 \
-vcl+backend {}
varnish v1 -start

delay 2
# we might have over-bred
delay 11

varnish v1 -expect threads == 2

Expand Down

0 comments on commit a24797a

Please sign in to comment.