Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Release Notes XPlatform plugin fails because of an item limit #508

Closed
ghost opened this issue Jun 12, 2019 · 5 comments
Closed

Comments

@ghost
Copy link

ghost commented Jun 12, 2019

Azure DevOps Extension you are using

Generate Release Notes XPlatform

Where are you running it?

  • Azure DevOps Service (VSTS)

Version of Extension/Task

2.9.6.

Expected behaviour and actual behaviour

Expected behaviour:
The plugin either generates a release note with the maximum amount of work items or retrieves them in multiple steps.

Actual behaviour:
2019-06-12T07:00:54.5966755Z ##[section]Starting: Generate Release Notes based on Release Comparision API
2019-06-12T07:00:54.7262502Z ==============================================================================
2019-06-12T07:00:54.7263107Z Task : Generate Release Notes XPlatform
2019-06-12T07:00:54.7263517Z Description : Generates a release notes file in a format of your choice from the release history
2019-06-12T07:00:54.7263916Z Version : 2.9.6
2019-06-12T07:00:54.7264263Z Author : Black Marble
2019-06-12T07:00:54.7264695Z Help : Version: 2.9.6. More Information
2019-06-12T07:00:54.7265185Z ==============================================================================
2019-06-12T07:00:56.5345058Z Getting the current release details
2019-06-12T07:00:56.5362945Z Getting the Environment Id
2019-06-12T07:00:56.5369991Z Identified [📄 generate release notes] as having id [43]
2019-06-12T07:00:56.5370429Z Getting all artifacts in the current release...
2019-06-12T07:00:56.5370990Z Found 1
2019-06-12T07:00:56.5396420Z Getting all artifacts in the most recent successful release [BatchedCI-Staging-B9488-R1]...
2019-06-12T07:00:56.5397054Z Found 1
2019-06-12T07:00:56.5397608Z Looking at artifact [exchange]
2019-06-12T07:00:56.5398067Z Artifact type [Build]
2019-06-12T07:00:56.5398526Z Build Definition ID [8]
2019-06-12T07:00:56.5399007Z Build Number: [BatchedCI-Staging-B10383]
2019-06-12T07:00:56.5399558Z Looking for the [exchange] in the most recent successful release [BatchedCI-Staging-B9488-R1]
2019-06-12T07:00:56.5400102Z Found artifact [exchange] with build number [BatchedCI-Staging-B9488] in release [BatchedCI-Staging-B9488-R1]
2019-06-12T07:00:56.5400631Z Checking what commits and workitems have changed from [BatchedCI-Staging-B9488] => [BatchedCI-Staging-B10383]
2019-06-12T07:00:57.5233038Z Detected 197 commits/changesets and 313 workitems between the builds.
2019-06-12T07:00:57.5233437Z
2019-06-12T07:00:57.5278818Z Expanding the truncated commit messages...
2019-06-12T07:01:08.4692578Z Finished expanding [120] commits.
2019-06-12T07:01:08.6086818Z ##[error]Error: VS403474: You requested 313 work items which exceeds the limit of 200
2019-06-12T07:01:08.6589114Z ##[error]Error: VS403474: You requested 313 work items which exceeds the limit of 200

2019-06-12T07:01:08.6637801Z ##[section]Finishing: Generate Release Notes based on Release Comparision API

Steps to reproduce the problem

Don't run the plugin for month...
For real: Try to let it generate release notes for more than 200 work items.

@rfennell
Copy link
Owner

This is a duplicated of #349 and there is a fix already in place, but it is a little hard to fix

You need to set release variables ReleaseNotes.Fix349.MaxCommits and ReleaseNotes.Fix349.MaxCommits to a number bigger than 300. This switches to other (slower API) calls that bypass the limitation

@ghost
Copy link
Author

ghost commented Jun 17, 2019

Well I am glad there is a fix available, but you pasted the same variable twice.
Setting that one to 500 didn't fix the problem for me and I can't find your solution in neither #349 nor #352 .

@rfennell rfennell reopened this Jun 17, 2019
@rfennell
Copy link
Owner

Sorry so I did make a mistake there. The line of code of interest is Ln 122 in GenerateReleaseNotes.ts with related logic here

  • To enable the fix set variable ReleaseNotes.Fix349 to true
  • The max items are then ReleaseNotes.Fix349.MaxCommits & ReleaseNotes.Fix349.MaxWorkItems

Let me know how it goes

1 similar comment
@rfennell
Copy link
Owner

Sorry so I did make a mistake there. The line of code of interest is Ln 122 in GenerateReleaseNotes.ts with related logic here

  • To enable the fix set variable ReleaseNotes.Fix349 to true
  • The max items are then ReleaseNotes.Fix349.MaxCommits & ReleaseNotes.Fix349.MaxWorkItems

Let me know how it goes

@ghost
Copy link
Author

ghost commented Jun 17, 2019

Worked like a charm.
Thank you very much.

@ghost ghost closed this as completed Jun 17, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant