Add coding conventions #21939
Merged
Add coding conventions #21939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Jul 30, 2019
|
@dstftw Requested changes made. Let me know if this works. |
dstftw
requested changes
Jul 31, 2019
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Aug 3, 2019
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Aug 3, 2019
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
This reverts commit 008825c.
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
This reverts commit d06257f.
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
This reverts commit 008825c.
Lamieur
referenced
this pull request
in Lamieur/youtube-dl
Apr 20, 2020
This reverts commit d06257f.
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
I added some coding conventions based on maintainers' reoccurring comments on pull requests. Issues included: inline values, collapsing fallbacks, and trailing parentheses. My hope is that these additions will save contributor's and maintainer's time.