Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically extract ASS subs when available #4019

Closed
ChrisK2 opened this issue Oct 24, 2014 · 1 comment
Closed

Automatically extract ASS subs when available #4019

ChrisK2 opened this issue Oct 24, 2014 · 1 comment
Assignees

Comments

@ChrisK2
Copy link

ChrisK2 commented Oct 24, 2014

(See #4003 for context)

We currently have to know beforehand if we want to have ASS subs, which requires a site-specific check, which we'd like to avoid. It would be good if ytdl would output ASS subs by default when available (in the case of CR, the SRT subs are completely broken anyway), or if it would be possible to specify an order of prefered formarts, just like for video:
--sub-format=ass/srt

jaimeMF added a commit that referenced this issue Oct 29, 2014
Parse the xml document instead of using regexes, otherwise unicode characters are left unescaped.
@jaimeMF jaimeMF self-assigned this Jan 10, 2015
@jaimeMF jaimeMF mentioned this issue Feb 16, 2015
19 tasks
@jaimeMF
Copy link
Collaborator

jaimeMF commented Feb 23, 2015

Thanks for the suggestion, it will work with the syntax you proposed in the next version (and in the case of crunchyroll it will default to ass).

@jaimeMF jaimeMF closed this as completed Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants