Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virDomainLookupByUUIDString (already available in 1.2.2) #61

Merged

Conversation

dmacvicar
Copy link
Collaborator

No description provided.

@rgbkrk
Copy link
Owner

rgbkrk commented Apr 5, 2016

Test + code ✅

I'd rather not introduce more public functions at the moment, especially as we gear toward Go 1.6. Will you be available to support this in the future? (Happy to add you on as another maintainer)

@rgbkrk
Copy link
Owner

rgbkrk commented Apr 5, 2016

Also, my apologies for letting this sit. Thank you for the contribution.

@dmacvicar
Copy link
Collaborator Author

Thanks for the review.

I am just upstreaming everything I needed for https://github.com/dmacvicar/terraform-provider-libvirt and I will certainly need to add more functions to my fork e.g. virDomainInterfaceAddresses on order to get the ip address of the domain in terraform.

It would be interesting to know if I should take the effort in upstreaming those. I have no problem to keep them in my fork.

@rgbkrk rgbkrk merged commit ff60ea0 into rgbkrk:master Apr 6, 2016
@rgbkrk
Copy link
Owner

rgbkrk commented Apr 6, 2016

Thanks @dmacvicar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants