This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Fix Android container not exported in m2e 1.6 #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2e 1.6 runs less configurator calls, which is a good thing, but has a bad side effect for m2e-android: our configurator will be called earlier, and the Android libraries container will not be found in the classpath, because it is only added after m2e-android ran. We call FixerWorkspaceConfigurer first, so we can make sure the container is added, then mark it as exported. https://github.com/rgladwell/m2e-android/issues/360 https://github.com/rgladwell/m2e-android/issues/353
|
👍 GREEN!!!! NICE!!! |
| @@ -44,7 +46,9 @@ protected void configure() { | |||
| classpathConfigurers.add(new ModifySourceFolderOutputClasspathConfigurer()); | |||
| classpathConfigurers.add(new RemoveJREClasspathContainerConfigurer()); | |||
| classpathConfigurers.add(new MarkMavenClasspathContianerExportedConfigurer()); | |||
| classpathConfigurers.add(new MarkAndroidClasspathContainerNotExportedConfigurer()); | |||
| if (!AndroidMavenProjectConfigurator.usesM2E1_6OrNewer()) { | |||
There was a problem hiding this comment.
👍 Nice way of maintaining backwards compatibility.
|
Other than the minor things I noted this looks excellent. |
|
I am glad this PR makes you happy. I think this is the most ugliest PR i ever wrote for this project. ;) |
|
Like I said before, this project is a lot of hacks. But I think this is how code evolves: we create a hack, then another, we see a similarity between hacks and create a common pattern, and slowly the code becomes safe. |
rgladwell
added a commit
that referenced
this pull request
Jul 3, 2015
Fix Android container not exported in m2e 1.6
|
OK, thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rgladwell check this out.