BLD: meson: fix Clang warnings coming from -Wno-unused-but-set-variable #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
pushed a commit
to czgdp1807/scipy
that referenced
this pull request
Jan 14, 2022
QUADPACK: dqk15w.f: line rgommers#103, wrong weights of the 7-point gauss rule The weights of wg should be the same as "dqk15.f": rgommers#103: "0.3818300505051889d+00", should be changed to "0.3818300505051189d+00". This is a historical typo that commonly exists in every code that embeds netlib-quadpack, which does not necessarily produce an actual numerical error in the calculation of the error of the quadrature using the Gauss-Kronrod rule. Reviewed/discussed in scipy#14807. An upstream fix at netlib/quadpack made on 05 Oct 2021, see scipy#14807 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings like these:
There was a warning for every C extension, so by far the noisiest problem on macOS.
There is still another somewhat noisy issue:
This is a known issue, see mesonbuild/meson#4651