Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package split #66

Closed
wants to merge 1 commit into from
Closed

Package split #66

wants to merge 1 commit into from

Conversation

rgrinberg
Copy link
Owner

Move mustache binary to a separate package to allow it to acquire extra deps.

@gasche did you make a decision on the package/binary name? I have no
preference, so I'll pick whatever you prefer.

Move mustache binary to a separate package to allow it to acquire extra
deps

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@gasche
Copy link
Collaborator

gasche commented Jan 10, 2021

My preference would be to not use mustache to avoid conflict with the semi-standard Ruby implementation. I don't have much of a preference as to which name to use (my only suggestion was mustacho and it's not, ahem, a particularly good one I think). If you were so inclined (and are willing to give it a week instead of a day), this sounds like something you could just ask the community about -- a Discuss thread or whatever -- also free publicity.

@gasche
Copy link
Collaborator

gasche commented Jan 10, 2021

(For context, we are talking about issue #61, "Consider changing the binary name".) I guess mustache-cli is also an option, but it's weird as it is both different and completely generic.

@gasche
Copy link
Collaborator

gasche commented Jan 10, 2021

(Thanks for the packaging work!)

@gasche
Copy link
Collaborator

gasche commented Jan 20, 2021

The CI fails on this PR:

- File "mustache-cli/dune", line 10, characters 7-15:
- 10 |   (run mustache --help=groff)))
-             ^^^^^^^^
- Error: Program mustache not found in the tree or in PATH
-  (context: default)

@gasche gasche mentioned this pull request May 17, 2021
psafont added a commit to psafont/ocaml-mustache that referenced this pull request Nov 24, 2023
This allows it to acquire extra dependencies

obsoletes rgrinberg#66

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
@psafont
Copy link
Collaborator

psafont commented Nov 27, 2023

The work has been merged as part of #71

@psafont psafont closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants