Rename CLI tool to mustache-ocaml, separate it into it's own package #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the output of the cli tool
This allows it to acquire extra dependencies obsoletes rgrinberg#66 Signed-off-by: Rudi Grinberg <me@rgrinberg.com> Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
resolves rgrinberg#61 Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
The delimiters used for a piece of ocaml code were not recognised fixes rgrinberg#72 Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
psafont
changed the title
|
I agree that this is a useful improvement, thanks! |
rgrinberg
approved these changes
Nov 25, 2023
Closed
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Dec 4, 2023
* [new release] mustache (2 packages) (3.3.0) CHANGES: * Rename the CLI tool to `mustache-ocaml`. It's now part of the new opam package `mustache-cli` (@psafont, rgrinberg/ocaml-mustache#71) * fixup! [new release] mustache (2 packages) (3.3.0)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
* [new release] mustache (2 packages) (3.3.0) CHANGES: * Rename the CLI tool to `mustache-ocaml`. It's now part of the new opam package `mustache-cli` (@psafont, rgrinberg/ocaml-mustache#71) * fixup! [new release] mustache (2 packages) (3.3.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following conversations around the name it looks like this naming was the most agreed upon, and I don't see much interest regarding the name so it looks like it's not very contentious :)
As always, comment from everybody are welcome