Adds the ability to specify a Proc which is used to validate @import URLs #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, the 1.9.3 build seems to be erroring. Trying to figure out what's going on there now. |
| @@ -381,6 +381,18 @@ Names of CSS [at-rules][at-rules] to allow that may have associated blocks | |||
| containing style rules. At-rules like `media` and `keyframes` fall into this | |||
| category. Names should be specified in lowercase. | |||
|
|
|||
| ##### :css => :at_import_url_validator | |||
There was a problem hiding this comment.
Could we call this :import_url_validator instead? I don't think the "at" adds anything useful to the name.
There was a problem hiding this comment.
Yeah, absolutely, I'll do that rename now. I was just trying to follow the existing naming but you're absolutely right.
|
Looks good, thanks! I wouldn't worry about the 1.9.3 failure on Travis. I can't reproduce it locally, so it seems like a Travis glitch. |
|
@rgrove done that rename, will see if Travis does the same thing this time around! |
|
Sweet, glitch seems gone ¯_(ツ)_/¯ |
|
Thanks! Will release this shortly as 4.1.0. |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first cut of the change described in #151.