Disabled GPIO slew rate config, which broke STM32 targets #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really the cause for your STM32 problems!? Wow! You are my hero. And I thought, that I'm doing something good to the interface signals when enabling fast edges with some power behind. But obviously this induces some other effects (reflections?). Could you please add a comment to the #ifdefs, so that playing around with the IOs will be done next time with more care. Hmmm... have you tried enabling Schmitt trigger on SWDIO? ;-) |
|
Comment added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #60 and #61. When interfacing with STM32 targets, setting the GPIO slew rate and drive strength seems to hinder yapicoprobe's ability to communicate. I have wrapped the offending configuration lines with
#if 0directives in case they are required for platforms other than the Pico, which I am using.