Fixed pickup running when it shouldn't in some cases. #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also needs to be adjusted in the Battle Pyramid check. |
|
Forgot about it, the feature is not on IE. |
AsparagusEduardo
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check only checked if the mon had an ability that was NOT the first one. So if the mon had it's hidden ability, index 2, the function would look for the second ability, index 1. If the species had pickup as the second ability, it would run a check for it. As a side note, this function is a bit wonky. Unnecessary nesting and repeated checks, but I decided to not touch any of that so the bug fix wouldn't get mixed with general refactoring.