Move battle tests off the heap #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts #3398 "Fix Broken Move Anims in Tests" which moved the AI logs to statically-allocated EWRAM_DATA instead of being part of gBattleTestRunnerState.
DizzyEggg
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pawkkie found a situation where adding just a small amount of data to
AiLogicDatacaused the tests to blow up. #3398 is a similar story where adding data toBattleTestRunnerStatecaused tests to blow up.This PR:
AllocreturnsNULL.gBattleTestRunnerStatealiassMapLayoutData, a 20kB buffer that goes unused in battle tests.It seems unlikely that anybody would write battle code which relies on, e.g.
MapGrid_GetMetatileAt, but if they do it will no longer work. Of course that would probably be broken in the tests anyway because they don't load a map, but the output will be much more confusing now.It's possible that in the future we'll want to write tests that check features work gracefully when out of heap, in which case we'll need to revisit my
Allocchange so that you can opt-out of the automatic failure.