fix warnings introduced by gcc 13 #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBird1337
force-pushed
the
fix/skydrop
branch
from
d7af60a
to
6793884
Compare
SBird1337
changed the title
those are introduced by some compiler between gcc 10 and gcc 13 when using -Wall
SBird1337
force-pushed
the
fix/skydrop
branch
from
6793884
to
4da710b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warnings introduced somewhere between gcc 10 and gcc 13 when compiling with
-Wall. Those warnings are-Warray-bounds-Waddress-Warray-parameterDescription
Ideally the skydrop stuff should be refactored to be a little more standalone I assume. However since with the current changes to upcoming the projects will stop to build on modern compilers that change the behavior of
-Walland-Warray-boundsit is probably a good idea to immediately remove the negative array subscript (which was broken due to theCMD_ARGSPR anyways)PR to
upcomingbecause it fixes anupcomingissue. The visual oddity technically exists inmaster, but I think it is fine for the next release version and does not require a hotfix. (Also this is not fixing the sprite invisibility issue)Issue(s) that this PR fixes
No issue was assigned to this.
Discord contact info
karathan