Don't try to deploy to GitHub Pages if it's not enabled #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the octokit/request-action action (which I believe is owned by GitHub?) to intentionally fail early if GitHub Pages isn't enabled for the repository, and allows the workflow to still succeed. This is mostly inconsequential, but prevents forks with Actions enabled but not Pages from having their
masterbranch marked as failing.I haven't seen any other repos that do anything like this, but @AlexOn1ine reported confusion from the failing workflow on Discord. It could conceivably also mask legitimate issues, but this would be rare.
Discord contact info
leo60228