Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing Move Effect TODO tests - Volume C #5094

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Added missing Move Effect TODO tests - Volume C #5094

merged 1 commit into from
Aug 7, 2024

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Aug 5, 2024 •
edited
Loading

Description

3rd part of a long-term plan of adding all missing TODO tests to the repository.
One of the few PRs I did while my power is out

Also:

  • Moved Copycat Dynamax test to the new test/battle/move_effect/copycat.c file.
  • Court Change and Lucky Chant never existed in the same Gen, so their interaction cannot be officially confirmed. Bulbapedia listed Aurora Veil instead, so I replaced Lucky Chant for it.

Discord contact info

AsparagusEduardo

@Pawkkie Pawkkie added the category: battle-tests Related to the automated test environment label Aug 6, 2024
@AlexOn1ine AlexOn1ine merged commit ce74c85 into rh-hideout:master Aug 7, 2024
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the _RHH/pr/master/moveEffectTestsC branch August 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexOn1ine AlexOn1ine AlexOn1ine approved these changes

Assignees
No one assigned
Labels
category: battle-tests Related to the automated test environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsparagusEduardo @AlexOn1ine @Pawkkie