Difference between true and apparent ecliptic and equatorial coordinates #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it hard to compare the results on this library with different sources like the IMCCE, NASA JPL, Heavens Above, etc.
The main reason is the difference of meaning of coordinates. Regarding the Sun, for example, books like Practical Astronomy or Celestial Calculations provide algorithms to calculate coordinates to the date (current epoch). There are in fact different definitions of coordinates:
While we already have a way to convert equatorial coordinates from one epoch to another, the current algorithms I have access to will provide only Sun ecliptic coordinates for the date's epoch.
I can still manage to make the difference between true and apparent coordinates, which is the purpose of this change.
This change removes
Astronoby::Sun#ecliptic_coordinates
andAstronoby::Coordinates::Ecliptic#to_equatorial
in favour of the following:Astronoby::Sun#true_ecliptic_coordinates
: true coordinatesAstronoby::Sun#apparent_ecliptic_coordinates
: include corrections for nutation and aberrationAstronoby::Coordinates::Ecliptic#to_true_equatorial
: true equatorial coordinates for the dateAstronoby::Coordinates::Ecliptic#to_apparent_equatorial
: include corrections for true obliquityAs you can see the difference is very subtle, but my goal is to provide accurate data and more importantly accurate concepts. I know this library still suffers from some approximations, but I aim to correct this problems over time.