Serializing null AutoValue object

[niqo01]

I am converting slowly my value objects to AutoValue with Gson extension.
I am having an issue for the following case:
(Pseudo code)

// Not an AutoValue (yet)
class A{
 B b;
}

@AutoValue
class B{
  public abstract Boolean enabled();

  public static TypeAdapter<B> typeAdapter(Gson gson) {
    return new AutoValue_B.GsonTypeAdapter(gson);
  }
}

When I am trying to serialize A with gson and B is null I am getting a NPE on the following line if (object.enabled() != null) inside $AutoValue_B:

    @Override
    public void write(JsonWriter jsonWriter, B object) throws IOException {
      jsonWriter.beginObject();
      if (object.enabled() != null) {
        jsonWriter.name("enabled");
        enabledAdapter.write(jsonWriter, object.enabled());
      }
      jsonWriter.endObject();
    }

because object is null.

[JakeWharton]

Call .nullSafe() on the TypeAdapter before registering it.

On Mon, Apr 18, 2016, 9:41 PM Nicolas Milliard notifications@github.com
wrote:

I am converting slowly my value objects to AutoValue with Gson extension.
I am having an issue for the following case:
(Pseudo code)

// Not an AutoValue (yet)
class A{
B b;
}

@autovalue
class B{
public abstract Boolean enabled();

public static TypeAdapter typeAdapter(Gson gson) {
return new AutoValue_B.GsonTypeAdapter(gson);
}
}

When I am trying to serialize A with gson and B is null I am getting a NPE
on the following line if (object.enabled() != null) inside $AutoValue_B:

@Override
public void write(JsonWriter jsonWriter, B object) throws IOException {
  jsonWriter.beginObject();
  if (object.enabled() != null) {
    jsonWriter.name("enabled");
    enabledAdapter.write(jsonWriter, object.enabled());
  }
  jsonWriter.endObject();
}

because object is null.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#28

[JakeWharton]

Keep in mind it returns a new null-safe instance which needs registered,
not modifies the existing one.

On Mon, Apr 18, 2016, 9:51 PM Jake Wharton jakewharton@gmail.com wrote:

Call .nullSafe() on the TypeAdapter before registering it.

On Mon, Apr 18, 2016, 9:41 PM Nicolas Milliard notifications@github.com
wrote:

I am converting slowly my value objects to AutoValue with Gson extension.
I am having an issue for the following case:
(Pseudo code)

// Not an AutoValue (yet)
class A{
B b;
}

@autovalue
class B{
public abstract Boolean enabled();

public static TypeAdapter typeAdapter(Gson gson) {
return new AutoValue_B.GsonTypeAdapter(gson);
}
}

When I am trying to serialize A with gson and B is null I am getting a
NPE on the following line if (object.enabled() != null) inside
$AutoValue_B:

@Override
public void write(JsonWriter jsonWriter, B object) throws IOException {
  jsonWriter.beginObject();
  if (object.enabled() != null) {
    jsonWriter.name("enabled");
    enabledAdapter.write(jsonWriter, object.enabled());
  }
  jsonWriter.endObject();
}

because object is null.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#28

[niqo01]

Thanks @JakeWharton. I missed that useful API.