Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing shared library doesn't install headers #66

Closed
kyrias opened this issue Mar 24, 2018 · 5 comments
Closed

Installing shared library doesn't install headers #66

kyrias opened this issue Mar 24, 2018 · 5 comments
Labels
as designed The code works as designed

Comments

@kyrias
Copy link

kyrias commented Mar 24, 2018

Only the static library install target actually installs the headers.

@kyrias
Copy link
Author

kyrias commented Mar 24, 2018

Looking closer, make install also doesn't install the .so symlink.)

@rhash
Copy link
Owner

rhash commented Mar 25, 2018

It's done on purpose. Sometime you need to install LibRHash shared library without headers and the symlinks. But static library is installed, when you want to compile something, and you obviously will need also headers and the symlink.

The .so symlink can be installed by command make install install-lib-so-link.

Headers can be installed by make -C librhash install-headers.

@kyrias
Copy link
Author

kyrias commented Mar 25, 2018

It feels like if you actually need that it's simpler to just delete the files after the fact than having a non-standard and undocumented way to fully install something.

@rhash
Copy link
Owner

rhash commented Mar 25, 2018

Ok, provide a link to a commonly accepted standard document and I change the installation behaviour.

@rhash
Copy link
Owner

rhash commented Apr 19, 2018

I've updated Makefile. Now one can install library and headers using command:

make install install-lib-so-link install-lib-headers

@rhash rhash closed this as completed Apr 19, 2018
@rhash rhash added the as designed The code works as designed label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
as designed The code works as designed
Projects
None yet
Development

No branches or pull requests

2 participants