Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running make repeatedly results in a rebuild of many targets #199

Closed
floppym opened this issue Jan 17, 2022 · 0 comments · Fixed by #200
Closed

Running make repeatedly results in a rebuild of many targets #199

floppym opened this issue Jan 17, 2022 · 0 comments · Fixed by #200

Comments

@floppym
Copy link
Contributor

floppym commented Jan 17, 2022

If I run make more than once with no changes to the source files, many of the targets get rebuilt. This should not happen.
floppym added a commit to floppym/efivar that referenced this issue Jan 17, 2022
@floppym
Adjust dependency for libefivar and libefiboot objects
847856c 
Depending on 'prep' causes all objects to be rebuilt every time 'make'
is invoked.

Depending on '$(GENERATED_SOURCES)' causes a build failure because
guid-symbols.c gets passed to the compiler due to a rule in rules.mk.

Depend on 'include/efivar/efivar-guids.h' directly to avoid these
issues.

Fixes: rhboot#199
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
@floppym floppym mentioned this issue Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust dependency for libefivar and libefiboot objects floppym/efivar
1 participant
@floppym