Skip to content

Commit

Permalink
mgr/dashboard: set appropriate baseline branch for applitools
Browse files Browse the repository at this point in the history
All the dashboard PRs are checked against a baseline branch called
'default' in the visual regresstion testing. This will cause issues when
testing PRs in different branches. For eg: currently our master and
pacific has to save two different screenshots since the two of them
differ slightly.

Disabling the applitools logs as well because its too 'noisy'

Fixes: https://tracker.ceph.com/issues/54190
Signed-off-by: Nizamudeen A <nia@redhat.com>
  • Loading branch information
nizamial09 committed Feb 9, 2022
1 parent 80ae7c3 commit 40c902a
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions src/pybind/mgr/dashboard/frontend/applitools.config.js
@@ -1,3 +1,12 @@
const fs = require('fs')
var branch = new String();

// Read the contents of the ceph_release file to retrieve
// the branch
fs.readFile('../../../../ceph_release', (_, data) => {
branch = data.toString().split('\n')[1];
});

module.exports = {
appName: 'Ceph Dashboard',
batchId: process.env.APPLITOOLS_BATCH_ID,
Expand All @@ -8,8 +17,9 @@ module.exports = {
{ width: 800, height: 600, name: 'chrome' },
{ width: 800, height: 600, name: 'firefox' }
],
showLogs: true,
showLogs: false,
saveDebugData: true,
failCypressOnDiff: true,
concurrency: 4
concurrency: 4,
baselineBranchName: branch
};

0 comments on commit 40c902a

Please sign in to comment.