Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone: for kickstart allow also timezones not offered by GUI (#145… #1149

Merged

Conversation

rvykydal
Copy link
Contributor

…2873)

Resolves: rhbz#1452873

For example Japan, which is linked to Asia/Tokyo in Olson tz database,
and we offer only Asia/Tokyo in GUI.

…2873)

Resolves: rhbz#1452873

For example Japan, which is linked to Asia/Tokyo in Olson tz database,
and we offer only Asia/Tokyo in GUI.
@rvykydal
Copy link
Contributor Author

For master, we should think about separating UI valid and (kickstart) valid timezones better in modules, ie shuffle stuff between spoke and timezone module, give better names to timezone module api methods etc.

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rvykydal rvykydal merged commit 63e8f01 into rhinstaller:rhel7-branch Aug 23, 2017
@rvykydal rvykydal deleted the rhel7-branch-japan-timezone branch August 23, 2017 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants