F27 devel fix leaving storage spoke with no disk #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1496327) Leaving the storage spoke with all disk unselected is currently there as a way to get back out of the spoke. In this special case the storage is not reset (to snapshot) when leaving the spoke, so it doesn't make sense to try to re-execute the storage on not updated (reset) device tree as we do. It would lead to invalid results (not enough space on the unselected disks which are actually used for execute/partitioning). Could resetting the storage/devicetree also in this special case help? It would not work because no selected disk in GUI just results in setting storage's exclusive_disks to empty list (with ignored_disks being kept empty list) which actually does not hide any disks in storage reset (leading to the invalid result described above). So let's just leave the spoke while ensuring it is in incomplete state (by setting the checker error to "No disks selected").
This would make debugging hangs and races (esp. of automated installs) easier. My only concern is that it can make some races more or less accessible. But it is not necessarily a bad thing - let's shake it a bit to see what happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.