Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F27 devel fix leaving storage spoke with no disk #1212

Merged
merged 2 commits into from Oct 12, 2017
Merged

F27 devel fix leaving storage spoke with no disk #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
908ed18
Do not execute storage when the spoke is left with no selected disk (…
rvykydal Oct 9, 2017
b092ef6
Add logging of complete spokes in GUI.
rvykydal Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyanaconda/ui/gui/hubs/__init__.py
View file
Open in desktop
Expand Up @@ -240,9 +240,11 @@ def _handleCompleteness(self, spoke, update_continue=True):
if not spoke.mandatory or spoke.completed:
if spoke in self._incompleteSpokes:
self._incompleteSpokes.remove(spoke)
log.debug("incomplete spokes: %s", self._incompleteSpokes)
else:
if spoke not in self._incompleteSpokes:
self._incompleteSpokes.append(spoke)
log.debug("incomplete spokes: %s", self._incompleteSpokes)

if update_continue:
self._updateContinue()
Expand Down
6 changes: 6 additions & 0 deletions pyanaconda/ui/gui/spokes/storage.py
View file
Open in desktop
Expand Up @@ -449,6 +449,12 @@ def _doExecute(self):
self._ready = True
hubQ.send_ready(self.__class__.__name__, True)
return
if not flags.automatedInstall and not self.selected_disks:
log.debug("not executing storage, no disk selected")
StorageCheckHandler.errors = [_("No disks selected")]
self._ready = True
hubQ.send_ready(self.__class__.__name__, True)
return
try:
doKickstartStorage(self.storage, self.data, self.instclass)
# ValueError is here because Blivet is returning ValueError from devices/lvm.py
Expand Down