Rhel7 branch non ibft boot #1437
Conversation
|
The patch for improving the UI feedback is dealing with propagating of storage check errors into UI where it seems easy to make a regression by trying to fix it too much, so (given it is 6th minor release) I decided to play conservative and safe here. I'll add inline comments for explanation.
|
pyanaconda/bootloader.py
Outdated
| if errors: | ||
| msg = msg + ": " + "; ".join(errors) | ||
| self.errors = errors | ||
| raise BootLoaderError(msg) |
There was a problem hiding this comment.
This (the exception msg) gets to the error detail dialog for autopartitiong case.
pyanaconda/bootloader.py
Outdated
| msg = "Failed to find a suitable stage1 device" | ||
| if errors: | ||
| msg = msg + ": " + "; ".join(errors) | ||
| self.errors = errors |
There was a problem hiding this comment.
The self.errors (self is a Bootloader instance) will be gathered when creating error details for custom partitioning.
Here the errors are collected locally in errors variable because is_valid_stage1_device clears the self.errors when called so older errors from the loop above would be lost.
|
@jkonecny12 |
|
jenkins, test this please |
1 similar comment
|
jenkins, test this please |
rvykydal
force-pushed
the
rhel7-branch-non-ibft-boot
branch
from
db0cf2a
to
11dac77
Compare
|
Added CI fixes (style guide: bootloader -> boot loader) |
|
jenkins, test this please |
The option allow placing bootloader on non-iBFT iSCSI disks Resolves: rhbz#1562301
rvykydal
force-pushed
the
rhel7-branch-non-ibft-boot
branch
from
11dac77
to
0e4eba4
Compare
|
@poncovka |
Related: rhbz#1562301
rvykydal
force-pushed
the
rhel7-branch-non-ibft-boot
branch
from
0e4eba4
to
9724f1e
Compare
|
Ported to master with 0236294 |
No description provided.