Do something about the new flood of pylint errors I caused #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the details of how Linux implements closing file descriptors and EINTR, retrying these calls is considered bad.
The subprocess module in python3 adds a special DEVNULL file, which simplifies things a little for us.
The future is now!
Python's builtin open will raise an execption if the underlying open system call returns with EINTR, which means that an ill-timed SIGALRM or SIGCHLD or anything happening from another thread could crash anaconda.
These will run before pyanaconda is available
Don't bother handling EINTR in test scripts and single-threaded scripts run outside of the anaconda environment
|
Holy crap. Ack. Thanks for tracking all these down. |
Same here, thanks and ACK! |
|
Pushed |
rvykydal
added a commit
that referenced
this pull request
Oct 17, 2017
…kage-cache packaging: clear downloaded packages repo cache before using it (#148…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.