Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do something about the new flood of pylint errors I caused #148

Closed
wants to merge 9 commits into from
Closed

Do something about the new flood of pylint errors I caused #148

wants to merge 9 commits into from

Commits on Jun 18, 2015

  1. Do not retry calls to close or dup2 

    Due to the details of how Linux implements closing file descriptors and
EINTR, retrying these calls is considered bad.
    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    f184fbb View commit details
    Browse the repository at this point in the history

  2. Remove explicit uses of /dev/null 

    The subprocess module in python3 adds a special DEVNULL file, which
simplifies things a little for us.
    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    fccbc30 View commit details
    Browse the repository at this point in the history

  3. Allow kwargs in eintr_retry_call

    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    14fa2f7 View commit details
    Browse the repository at this point in the history

  4. Use python 3's OSError subclasses instead of checking errno

    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    b4b7c75 View commit details
    Browse the repository at this point in the history

  5. Remove __future__ imports 

    The future is now!
    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    d9ed184 View commit details
    Browse the repository at this point in the history

  6. Redefine open to retry on EINTR 

    Python's builtin open will raise an execption if the underlying open
system call returns with EINTR, which means that an ill-timed SIGALRM or
SIGCHLD or anything happening from another thread could crash anaconda.
    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    f9b8199 View commit details
    Browse the repository at this point in the history

  7. Wrap the only non-open call found by the new pocketlint checks

    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    b61053f View commit details
    Browse the repository at this point in the history

  8. Reimplement the open override for the dracut scripts 

    These will run before pyanaconda is available
    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    55423e2 View commit details
    Browse the repository at this point in the history

  9. Ignore EINTR errors in files unlikely to encounter them 

    Don't bother handling EINTR in test scripts and single-threaded scripts
run outside of the anaconda environment
    @dashea
    dashea committed Jun 18, 2015
    Configuration menu
    Copy the full SHA
    865e216 View commit details
    Browse the repository at this point in the history