-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wwn attr instead of removed wwid. (#1565693) #1503
Use wwn attr instead of removed wwid. (#1565693) #1503
Conversation
The 'wwid' attribute was removed in blivet-3.1.0. Now all disk-like devices have a 'wwn' attribute that gets its value from udev's ID_WWN_WITH_EXTENSION property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
jenkins, test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
Also I'm not sure if this is happening because of my settings but when I'm trying to attach 1 disk from 2 different ip addresses there is no wwn value showed. Do you know why it is not there? Also I think we need to change tab name to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to solve that crash above.
This looks correct, however it looks that there is a bug in blivet. Based on my tests the wwn attribute is empty for multipath device. I was looking into that in debugger and the Another question is if the |
Ohh I see you already have PR for that. Then please leave here a note when new blivet with this fix will be released. |
I'm planning to build blivet-3.1.0.b2 (storaged-project/blivet@cd698c04) on Tuesday (tomorrow) for rawhide. I don't have firm plans for any other builds as of now. |
OK thanks, I will test and merge this tomorrow. |
I've tested the PR with latest rawhide Fedora-Rawhide-20180802.n.0 and it seem to be good. |
The 'wwid' attribute was removed in blivet-3.1.0. Now all disk-like
devices have a 'wwn' attribute that gets its value from udev's
ID_WWN_WITH_EXTENSION property.
This supercedes #1499 and also fixes the display formatting issue contained therein.