Allow to detect devices with the iso9660 file system as optical media #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @poncovka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-07-21 18:03:14 UTC |
poncovka
force-pushed
the
rhel-8-nvdimm_iso9660
branch
2 times, most recently
from
fbf8e7f
to
9c14d83
Compare
M4rtinK
approved these changes
Jul 21, 2020
|
jenkins, test this please |
1 similar comment
|
jenkins, test this please |
jkonecny12
approved these changes
Jul 21, 2020
Test that the method identifies devices with the iso9660 file system as optical media, so it is able to find NVDIMM devices with iso9660. Related: rhbz#1856264
The DBus method GetDevicesToIgnore of the NVDIMM module shouldn't return NVDIMM devices with the iso9660 file system. They can be used as an installation source. Related: rhbz#1856264
It will protect, for example, NVDIMM devices with the iso9660 file system that can be used only as an installation source anyway. Related: rhbz#1856264
poncovka
force-pushed
the
rhel-8-nvdimm_iso9660
branch
from
9c14d83
to
4bcabe9
Compare
|
I have replaced one of the commits with unit tests. The implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that the DBus method FindOpticalMedia identifies devices with the iso9660 file
system as optical media, so it is able to find NVDIMM devices with iso9660.
The DBus method GetDevicesToIgnore of the NVDIMM module shouldn't return NVDIMM
devices with the iso9660 file system. They can be used as an installation source.
Protect all devices with the iso9660 file system. It will protect, for example, NVDIMM
devices with the iso9660 file system that can be used only as an installation source
anyway.
Related: rhbz#1856264