Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for the nfsiso: pseudo-protocol #2889

Merged

Conversation

VladimirSlavik
Copy link
Contributor

@VladimirSlavik VladimirSlavik commented Oct 2, 2020

It was already deprecated, because Anaconda can automatically detect that an NFS location is an ISO image.

TODO:

  • test it

@VladimirSlavik VladimirSlavik added master Please, use the `f39` label instead. manual testing required This issue can't be merged without manual testing labels Oct 2, 2020
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thanks!

@poncovka poncovka added the notable change Important changes like API change, behavior change... label Oct 5, 2020
@VladimirSlavik VladimirSlavik removed the manual testing required This issue can't be merged without manual testing label Oct 5, 2020
@VladimirSlavik VladimirSlavik marked this pull request as ready for review October 5, 2020 10:49
It was already deprecated, because Anaconda can automatically detect that an
NFS location is an ISO image.
@VladimirSlavik
Copy link
Contributor Author

Rebased to solve conflict in docs with the other removal PR.

@VladimirSlavik VladimirSlavik merged commit 3215b19 into rhinstaller:master Oct 7, 2020
@VladimirSlavik VladimirSlavik deleted the master-remove-nfsiso branch October 7, 2020 09:02
@jkonecny12
Copy link
Member

I had this on my TODO for some time already. Thanks for making it done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead. notable change Important changes like API change, behavior change...
Development

Successfully merging this pull request may close these issues.

3 participants